Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #332 +/- ##
=============================================
+ Coverage 50.38% 72.05% +21.67%
- Complexity 114 162 +48
=============================================
Files 16 16
Lines 526 526
Branches 49 49
=============================================
+ Hits 265 379 +114
+ Misses 246 123 -123
- Partials 15 24 +9 see 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fe75080 to
2a44a37
Compare
Member
Author
|
fyi @jglick |
uhafner
approved these changes
Apr 19, 2023
Member
uhafner
left a comment
There was a problem hiding this comment.
Would be much simpler to review if not all tests were deleted a couple of hours before. But anyway, thanks for fixing so fast...
Member
|
Aggregate diff, with some other stuff mixed in: f4c1127...4e4c250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
see #307